This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21788 ) Change subject: power_control: send ip.access specific meas processing defaults ...................................................................... power_control: send ip.access specific meas processing defaults Thanks to this message, there is no need to include MS/BS Power Control parameters in every RSL CHANnel ACTIvation message. Instead, we send them only once, and then send empty IEs. Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d Related: SYS#4918 --- M include/osmocom/bsc/abis_rsl.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/21788/1 diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h index 964e282..81a0224 100644 --- a/include/osmocom/bsc/abis_rsl.h +++ b/include/osmocom/bsc/abis_rsl.h @@ -101,6 +101,8 @@ /* required for Nokia BTS power control */ int rsl_bs_power_control(struct gsm_bts_trx *trx, uint8_t channel, uint8_t reduction); +/* ip.access specific "Measurement Pre-processing Defaults" */ +int rsl_tx_ipacc_meas_preproc_def(struct gsm_bts_trx *trx); int rsl_release_sapis_from(struct gsm_lchan *lchan, int start, enum rsl_rel_mode release_mode); diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 917726a..27d0dad 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2642,3 +2642,30 @@ return abis_rsl_sendmsg(msg); } + +/* ip.access specific "Measurement Pre-processing Defaults" */ +int rsl_tx_ipacc_meas_preproc_def(struct gsm_bts_trx *trx) +{ + struct msgb *msg = rsl_msgb_alloc(); + struct abis_rsl_common_hdr *ch; + + ch = (struct abis_rsl_common_hdr *) msgb_put(msg, sizeof(*ch)); + ch->msg_discr = ABIS_RSL_MDISC_TRX; + ch->msg_type = RSL_MT_IPAC_MEAS_PREPROC_DFT; + + /* BS/MS Power IEs (to be re-defined in channel specific messages) */ + if (trx->bts->ms_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE) + msgb_tv_put(msg, RSL_IE_MS_POWER, 0); /* maximum */ + if (trx->bts->bs_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE) + msgb_tv_put(msg, RSL_IE_BS_POWER, 0); /* no attenuation */ + + /* BS/MS Power Parameters IEs (if supported by BTS model) */ + add_power_control_params(msg, trx->bts, GSM_PWR_CTRL_DIR_UL); + add_power_control_params(msg, trx->bts, GSM_PWR_CTRL_DIR_DL); + + /* TODO: "Pre-processing Parameters" IE can be sent in subsequent messages */ + + msg->dst = trx->rsl_link; + + return abis_rsl_sendmsg(msg); +} diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index df5235e..7be594a 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -340,6 +340,12 @@ rsl_nokia_si_end(trx); } + /* ip.access specific "Measurement Pre-processing Defaults" */ + if (is_ipaccess_bts(trx->bts) && + (trx->bts->ms_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE || + trx->bts->bs_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE)) + rsl_tx_ipacc_meas_preproc_def(trx); + for (i = 0; i < ARRAY_SIZE(trx->ts); i++) { struct gsm_bts_trx_ts *ts = &trx->ts[i]; generate_ma_for_ts(ts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d Gerrit-Change-Number: 21788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201218/02d51ca7/attachment.htm>