Change in osmo-sgsn[master]: gbproxy: Add "show gbproxy cell ..." VTY command

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Dec 18 10:42:09 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 )

Change subject: gbproxy: Add "show gbproxy cell ..." VTY command
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c 
File src/gbproxy/gb_proxy_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c@251 
PS7, Line 251: DEFUN(show_gbproxy_cell, show_gbproxy_cell_cmd, "show gbproxy cell [stats]",
> This looks wrong to me: you have 4 words in the command vector, and 5 docstrings?
nice catch. Indeed I was first thinking of adding an additional qualifier like "all" which we can then later exntend with some other qualifier like "bvci ..." or "cell-id ..."

But I guess we can do the same without that "all". Will fix.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5
Gerrit-Change-Number: 21692
Gerrit-PatchSet: 8
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Fri, 18 Dec 2020 10:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201218/495273d0/attachment.htm>


More information about the gerrit-log mailing list