This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21713 ) Change subject: GPRS Cell Options (SI13): Add REL-4 CCN_ACTIVE bit ...................................................................... GPRS Cell Options (SI13): Add REL-4 CCN_ACTIVE bit This is required in order to tell MS that osmo-pcu now supports Network Assisted Cell Change (NACC). Related: SYS#4909 Change-Id: I2aaa8c1107c977f711c2d7530034f57e36e3a237 --- M TODO-RELEASE M include/osmocom/gprs/protocol/gsm_04_60.h M src/gsm/gsm48_rest_octets.c 3 files changed, 9 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 7699aff..33e27af 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,5 +8,6 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmogsm new API gsm0808_create_sapi_reject_cause() with cause argument +libosmogsm ABI change struct osmo_gprs_cell_options size changed (new field at the end) libosmovty ABI change struct cmd_element: add a field for program specific attributes libosmovty ABI change struct vty_app_info: optional program specific attributes description diff --git a/include/osmocom/gprs/protocol/gsm_04_60.h b/include/osmocom/gprs/protocol/gsm_04_60.h index 05728f4..ed63fe0 100644 --- a/include/osmocom/gprs/protocol/gsm_04_60.h +++ b/include/osmocom/gprs/protocol/gsm_04_60.h @@ -167,7 +167,7 @@ GPRS_NMO_III = 2, /* no paging coordination */ }; -/* TS 04.60 12.24 */ +/* TS 44.060 12.24 */ struct osmo_gprs_cell_options { enum osmo_gprs_nmo nmo; /* T3168: wait for packet uplink assignment message */ @@ -187,6 +187,7 @@ uint8_t pfc_supported; uint8_t dtm_supported; uint8_t bss_paging_coordination; + bool ccn_active; } ext_info; }; diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index 1f9c2b5..3a424f7 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -906,6 +906,8 @@ bitvec_set_bit(bv, 0); } else { /* extension information */ + + /* R99 extension: */ bitvec_set_bit(bv, 1); if (!gco->ext_info.egprs_supported) { /* 6bit length of extension */ @@ -927,6 +929,10 @@ bitvec_set_bit(bv, gco->ext_info.pfc_supported); bitvec_set_bit(bv, gco->ext_info.dtm_supported); bitvec_set_bit(bv, gco->ext_info.bss_paging_coordination); + + /* REL-4 extension: */ + bitvec_set_bit(bv, gco->ext_info.ccn_active); + bitvec_set_bit(bv, 0); /* NW_EXT_UTBF disabled */ } return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2aaa8c1107c977f711c2d7530034f57e36e3a237 Gerrit-Change-Number: 21713 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201217/b1fe93e9/attachment.htm>