This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21747 ) Change subject: gprs_ns2_vty: udp: fixup dialect changes ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21747/2/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21747/2/src/gb/gprs_ns2_vty.c@905 PS2, Line 905: bind->accept_ipaccess = priv.vc_mode == NS2_VC_MODE_BLOCKRESET; : } i'd prefer an if/else clause here, it's hard to understand the above as a double-assignment. but we can merge it as is. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia787528b1a6fac6bf1570c21643ef6cd8c209108 Gerrit-Change-Number: 21747 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 16 Dec 2020 20:42:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201216/ce967005/attachment.htm>