Change in libosmocore[master]: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 15 09:48:16 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21709 )

Change subject: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
......................................................................

gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

Cherry-pick from osmo-bsc.git e981f17200bf3a5d5114f46d9f7515fd10b96dbb

Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index dd14d28..84b7589 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -909,13 +909,8 @@
 			/* EGPRS supported in the cell */
 			bitvec_set_bit(bv, 1);
 
-			/* 1bit EGPRS PACKET CHANNEL REQUEST */
-			if (gco->supports_egprs_11bit_rach == 0) {
-				bitvec_set_bit(bv,
-					gco->ext_info.use_egprs_p_ch_req);
-			} else {
-				bitvec_set_bit(bv, 0);
-			}
+			/* 1bit EGPRS PACKET CHANNEL REQUEST (inverted logic) */
+			bitvec_set_bit(bv, !gco->ext_info.use_egprs_p_ch_req);
 
 			/* 4bit BEP PERIOD */
 			bitvec_set_uint(bv, gco->ext_info.bep_period, 4);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
Gerrit-Change-Number: 21709
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201215/247218ae/attachment.htm>


More information about the gerrit-log mailing list