This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21725 ) Change subject: gprs_ns2: don't pass the return code of reject_status_msg ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21725/2/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21725/2/src/gb/gprs_ns2.c@835 PS2, Line 835: LOGP(DLNS, LOGL_ERROR, "Failed to generate reject message (%d)\n", rc); one could have a "goto" target that prints that log line and returns CS_REJECTED? This way we could avoid stating the same log line over and over again. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I105363957e59c41a68835b7a9830c048dba73e93 Gerrit-Change-Number: 21725 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 15 Dec 2020 09:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201215/b5d8748f/attachment.htm>