Change in osmo-sgsn[master]: gbproxy: rename vty command "show gbproxy ..." to "show gbproxy bvc ..."

[daniel]

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21691 )

Change subject: gbproxy: rename vty command "show gbproxy ..." to "show gbproxy bvc ..."
......................................................................

gbproxy: rename vty command "show gbproxy ..." to "show gbproxy bvc ..."

we have other objects to show, and the orthogoanl way to do this is
to rename the existing one.

Change-Id: I7836a37533a2de81720acedda712d61f429df12c
---
M src/gbproxy/gb_proxy_vty.c
M tests/vty_test_runner.py
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved



diff --git a/src/gbproxy/gb_proxy_vty.c b/src/gbproxy/gb_proxy_vty.c
index 976ac12..fc2e8f1 100644
--- a/src/gbproxy/gb_proxy_vty.c
+++ b/src/gbproxy/gb_proxy_vty.c
@@ -198,8 +198,9 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(show_gbproxy, show_gbproxy_cmd, "show gbproxy (bss|sgsn) [stats]",
+DEFUN(show_gbproxy_bvc, show_gbproxy_bvc_cmd, "show gbproxy bvc (bss|sgsn) [stats]",
        SHOW_STR "Display information about the Gb proxy\n"
+       "Show BSSGP Virtual Connections\n"
        "Display BSS-side BVCs\n"
        "Display SGSN-side BVCs\n"
        "Show statistics\n")
@@ -334,7 +335,7 @@
 
 int gbproxy_vty_init(void)
 {
-	install_element_ve(&show_gbproxy_cmd);
+	install_element_ve(&show_gbproxy_bvc_cmd);
 	install_element_ve(&show_gbproxy_links_cmd);
 	install_element_ve(&logging_fltr_bvc_cmd);
 
diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py
index be40abc..4fb67cb 100755
--- a/tests/vty_test_runner.py
+++ b/tests/vty_test_runner.py
@@ -97,7 +97,7 @@
         res = self.vty.command("show ns")
         self.assertTrue(res.find('UDP bind') >= 0)
 
-        res = self.vty.command("show gbproxy bss stats")
+        res = self.vty.command("show gbproxy bvc bss stats")
         self.assertTrue(res.find('GBProxy Global Statistics') >= 0)
 
     def testVtyDeletePeer(self):

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21691
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I7836a37533a2de81720acedda712d61f429df12c
Gerrit-Change-Number: 21691
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201214/629c5400/attachment.htm>