Change in osmo-ttcn3-hacks[master]: gbproxy: Fix log messages in timeout situations

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Dec 11 10:00:28 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21671 )


Change subject: gbproxy: Fix log messages in timeout situations
......................................................................

gbproxy: Fix log messages in timeout situations

Printing an unbound 'rx' variable when nothing was received due to
timeout is somehow not really useful.  Print what we expected to
receive.

Change-Id: I4fee89baa954736ae8298b63667297dd57d8ec4f
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/21671/1

diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 655e396..2077e0f 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -765,7 +765,7 @@
 		mtc.stop;
 		}
 	[] T.timeout {
-		setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ", rx);
+		setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ", exp_rx);
 		mtc.stop;
 		}
 	}
@@ -788,7 +788,7 @@
 		mtc.stop;
 		}
 	[] T.timeout {
-		setverdict(fail, "Timeout waiting for BSSGP on PCU side: ", rx);
+		setverdict(fail, "Timeout waiting for BSSGP on PCU side: ", exp_rx);
 		mtc.stop;
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4fee89baa954736ae8298b63667297dd57d8ec4f
Gerrit-Change-Number: 21671
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201211/01c1c2ec/attachment.htm>


More information about the gerrit-log mailing list