Change in osmo-gsm-tester[master]: log passed tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Dec 10 23:42:06 UTC 2020


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21509 )

Change subject: log passed tests
......................................................................

log passed tests

In the end of a test suite, do not omit the passed tests. For example,
running handover against N BTS combinations, it was hard to summarize
which BTS models actually succeeded, with only the failures listed.

Besides the "FAIL" listings, now print something like this in the end:

 PASS: handover:sysmo+secondbts-trx-b200 (pass: 1)
     pass: handover.py (198.8 sec)
 PASS: handover:sysmo+secondbts-trx-umtrx (pass: 1)
     pass: handover.py (192.7 sec)
 PASS: handover:trx-b200+secondbts-trx-umtrx (pass: 1)
     pass: handover.py (193.1 sec)

Change-Id: Ib85a5b90e267c2ed2f844691187ecadc8939b1bb
---
M src/osmo_gsm_tester/core/report.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/core/report.py b/src/osmo_gsm_tester/core/report.py
index d2c68c5..c3390fe 100644
--- a/src/osmo_gsm_tester/core/report.py
+++ b/src/osmo_gsm_tester/core/report.py
@@ -164,12 +164,14 @@
     return testcase
 
 def trial_to_text(trial):
+    suite_passes = []
     suite_failures = []
     count_fail = 0
     count_pass = 0
     for suite in trial.suites:
         if suite.passed():
             count_pass += 1
+            suite_passes.append(suite_to_text(suite))
         else:
             count_fail += 1
             suite_failures.append(suite_to_text(suite))
@@ -181,6 +183,7 @@
         summary.append('%d suites passed' % count_pass)
     msg = [', '.join(summary)]
     msg.extend(suite_failures)
+    msg.extend(suite_passes)
     return '\n'.join(msg)
 
 def suite_to_text(suite):

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib85a5b90e267c2ed2f844691187ecadc8939b1bb
Gerrit-Change-Number: 21509
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/174b1715/attachment.htm>


More information about the gerrit-log mailing list