Change in osmo-sgsn[master]: gbproxy: Don't create an extra msgb copy for SGSN DL SIG

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Dec 10 17:21:04 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21615 )

Change subject: gbproxy: Don't create an extra msgb copy for SGSN DL SIG
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21615/4/src/gbproxy/gb_proxy.c 
File src/gbproxy/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21615/4/src/gbproxy/gb_proxy.c@929 
PS4, Line 929: 		msgb_free(msg);
> We should not free the msg here at all, this is done in gprs_ns_prim_status_cb()
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21615/4/src/gbproxy/gb_proxy.c@1030 
PS4, Line 1030: 	msgb_free(msg);
> Same (and it's used in the line just below)
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21615
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I207a869ffac8bf60104f80f9ed58faf0021e5e95
Gerrit-Change-Number: 21615
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Dec 2020 17:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/e3c351da/attachment.htm>


More information about the gerrit-log mailing list