Change in osmocom-bb[master]: firmware/layer1: invalidate hard-coded Measurement results

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Dec 10 15:25:09 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21422 )

Change subject: firmware/layer1: invalidate hard-coded Measurement results
......................................................................

firmware/layer1: invalidate hard-coded Measurement results

This is what the L1 sends to the network before the first SACCH
block is received from the higher layers.  The indicated values
are of course invalid because they're hard-coded.

According to 3GPP TS 44.018, table 10.5.2.20.1:

  0  The measurement results are valid
  1  The measurement results are not valid

Change-Id: I136307baef3fa2ddd1d5cec2a7f8c9e6d4602499
Related: I7da767e146aec7cef1de71e4d735d6a02b6c5642
Related: SYS#4918
---
M src/target/firmware/layer1/prim_utils.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/target/firmware/layer1/prim_utils.c b/src/target/firmware/layer1/prim_utils.c
index 9c58d15..7beab5f 100644
--- a/src/target/firmware/layer1/prim_utils.c
+++ b/src/target/firmware/layer1/prim_utils.c
@@ -51,13 +51,13 @@
 	 *   .0.. .... = DTX-USED: DTX was not used
 	 *   ..11 0110 = RXLEV-FULL-SERVING-CELL: -57 <= x < -56 dBm (54)
 	 *   0... .... = 3G-BA-USED: 0
-	 *   .0.. .... = MEAS-VALID: The measurement results are valid
+	 *   .1.. .... = MEAS-VALID: The measurement results are not valid
 	 *   ..11 0110 = RXLEV-SUB-SERVING-CELL: -57 <= x < -56 dBm (54)
 	 *   0... .... = SI23_BA_USED: 0
 	 *   .000 .... = RXQUAL-FULL-SERVING-CELL: BER < 0.2%, Mean value 0.14% (0)
 	 *   .... 000. = RXQUAL-SUB-SERVING-CELL: BER < 0.2%, Mean value 0.14% (0)
 	 *   .... ...1  11.. .... = NO-NCELL-M: Neighbour cell information not available */
-	0x36, 0x36, 0x01, 0xc0, 0x00, 0x00, 0x00, 0x00,
+	0x36, 0x76, 0x01, 0xc0, 0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I136307baef3fa2ddd1d5cec2a7f8c9e6d4602499
Gerrit-Change-Number: 21422
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/ef9385b9/attachment.htm>


More information about the gerrit-log mailing list