This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21607 ) Change subject: NM FSMs: fix DISABLED_NOTINSTALLED -> DISABLED_NOTINSTALLED ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > Wouldn't it make sense to handle this inside the macro/inline-functions? > > If you check inside nm_bb_transc_fsm_state_chg(), then you don't have to change the callers, and it would be a genric solution. > > In fact, we could even consider introducing an osmo_fsm flag that would make such transitions quiet for certain fsm "classes" that set the flag. I am not sure if blocking loop-transitions is valid for all other states. Maybe in some state(s) it's expected to leave and enter the same state again to re-initialize something? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I24a78905bb684f8501dc5ade0605662ec283febc Gerrit-Change-Number: 21607 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 10 Dec 2020 13:05:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/e4d6276b/attachment.htm>