Change in osmo-bsc[master]: handover_tests: add expected output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Dec 10 02:29:09 UTC 2020


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21645 )


Change subject: handover_tests: add expected output
......................................................................

handover_tests: add expected output

I am not sure whether we want to keep the expected log output of
handover tests in the source tree.

On the one hand, it is pretty nice to see how changes to the code affect
logging and the internal flow of things, and follow that in the history.
'make update_exp' makes it easy to update expected outputs.

On the other hand, those logs are a lot of cruft to keep. They will
often change as osmo-bsc changes. We've seen similar in the osmo-msc.git
msc_vlr_tests, I believe sometimes annoying some of us. The test script
only uses the expected log outputs when they are actually present, so it
is always an option for each developer to locally do 'make update_exp'
and diff between source versions like that, without the logs having to
be in version control.

I will leave it up to code review whether to add these logs or not.

Change-Id: I387aa62eb2dd9896494aefa32e6d336106e0ecdc
---
M tests/handover/handover_tests.sh
A tests/handover/test_amr_tch_f_to_h.ho_vty.err
A tests/handover/test_amr_tch_f_to_h.ho_vty.ok
A tests/handover/test_amr_tch_f_to_h_balance_congestion.ho_vty.err
A tests/handover/test_amr_tch_f_to_h_balance_congestion.ho_vty.ok
A tests/handover/test_amr_tch_f_to_h_congestion.ho_vty.err
A tests/handover/test_amr_tch_f_to_h_congestion.ho_vty.ok
A tests/handover/test_amr_tch_f_to_h_congestion_assignment.ho_vty.err
A tests/handover/test_amr_tch_f_to_h_congestion_assignment.ho_vty.ok
A tests/handover/test_amr_tch_f_to_h_congestion_assignment_2.ho_vty.err
A tests/handover/test_amr_tch_f_to_h_congestion_assignment_2.ho_vty.ok
A tests/handover/test_amr_tch_f_to_h_congestion_assignment_3.ho_vty.err
A tests/handover/test_amr_tch_f_to_h_congestion_assignment_3.ho_vty.ok
A tests/handover/test_balance_congestion.ho_vty.err
A tests/handover/test_balance_congestion.ho_vty.ok
A tests/handover/test_balance_congestion_2.ho_vty.err
A tests/handover/test_balance_congestion_2.ho_vty.ok
A tests/handover/test_congestion.ho_vty.err
A tests/handover/test_congestion.ho_vty.ok
A tests/handover/test_disabled_ho_and_as.ho_vty.err
A tests/handover/test_disabled_ho_and_as.ho_vty.ok
A tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty.err
A tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty.ok
A tests/handover/test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty.err
A tests/handover/test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty.ok
25 files changed, 5,192 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/21645/1


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21645
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I387aa62eb2dd9896494aefa32e6d336106e0ecdc
Gerrit-Change-Number: 21645
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/e338e1c4/attachment.htm>


More information about the gerrit-log mailing list