Change in libosmocore[master]: ns2: Accept NS-UNBLOCK-ACK in UNBLOCKED state

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 8 06:54:13 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21589 )

Change subject: ns2: Accept NS-UNBLOCK-ACK in UNBLOCKED state
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21589/1/src/gb/gprs_ns2_vc_fsm.c 
File src/gb/gprs_ns2_vc_fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/21589/1/src/gb/gprs_ns2_vc_fsm.c@403 
PS1, Line 403: 		.in_event_mask = S(GPRS_NS2_EV_BLOCK) | S(GPRS_NS2_EV_UNBLOCK_ACK),
> Let's try to put one per line please, it's much clearer when trying to understand the FSM.
this file (which I didn't write) already isn't formatted this way, and this patch just follows the existing style of the surrounding code.  Anyone is free to submit a reformat-patch.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21589
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icc4d960ddad82e3ebbf571d8ff9f24854b52a946
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Dec 2020 06:54:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201208/e9209268/attachment.htm>


More information about the gerrit-log mailing list