Change in osmo-gsm-tester[master]: add handover_2G suite, with handover.py test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Dec 7 10:50:23 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 )

Change subject: add handover_2G suite, with handover.py test
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py 
File sysmocom/suites/handover_2G/handover.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py@91 
PS2, Line 91: with bsc.ctrl() as bsc_ctrl:
> I'd use testenv. […]
BTW, I'd do that ofc inside the obj class, so test doesn't need to care about those details.

That way you don't end up having tests full of indented with statements.

You simply do: bsc_vty = bsc.vty(), and use bsc_vty, and testenv takes care of cleaning up everything at the end of test, no matter if it passed or failed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I0b2671304165a1aaae2b386af46fbd8b098e3bd8
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Dec 2020 10:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201207/46f6ce67/attachment.htm>


More information about the gerrit-log mailing list