Change in libosmocore[master]: bssgp: Add osmo_tlv_prot_def for BSSGP

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21544 )

Change subject: bssgp: Add osmo_tlv_prot_def for BSSGP
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c 
File src/gb/gprs_bssgp_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c@209 
PS1, Line 209: static const uint8_t crt_bss_pfc_nack_ies[] = { BSSGP_IE_TLLI, BSSGP_IE_PACKET_FLOW_ID, BSSGP_IE_CAUSE };
> I'm not sure I understand your suggestion. […]
#define DECLR_TLV_IE(name) static const uint8_t name_ies
#define DEF_TLV_IE(name, str) [name] = MSG_DEF(str, name_ies),


Then, for instance:

DECLR_TLV_IE(BSSGP_PDUT_DL_UNITDATA) = { BSSGP_IE_PDU_LIFETIME };
...
msg_def = {
DEF_TLV_IE(BSSGP_PDUT_DL_UNITDATA, "DL-UNITDATA"),
...

Just as an idea, not saying it needs to be done this way.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21544
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7e4226463f3c935134b5c2c737696fbfd1dd5815
Gerrit-Change-Number: 21544
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Dec 2020 10:00:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201207/70a49a58/attachment.htm>