Change in osmo-gsm-tester[master]: process: add get_output_mark() and grep_output()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Dec 6 22:17:36 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21512 )

Change subject: process: add get_output_mark() and grep_output()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21512/2/src/osmo_gsm_tester/core/process.py 
File src/osmo_gsm_tester/core/process.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21512/2/src/osmo_gsm_tester/core/process.py@388 
PS2, Line 388:     def get_stdout_mark(self):
> Using this with get_stdout looks like a source of all Earth problem. […]
i don't see any race, really. it's not like the stdout is being "piped away", this is process.py returning all of the stdout recorded so far, and it is constantly growing. The returned mark is just an integer that remains valid until the process object is discarded, no matter how many marks are requested. Am I missing something?

But i don't actually use the get_stdout* and get_stderr* variants, i end up using only get_output_mark(which='stderr') and grep_output(which='stderr') in my code. So I see unused API creep.

I never heard of "source of all Earth"?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21512
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib6569f7486e9d961bd79a5f24232e58d053667a1
Gerrit-Change-Number: 21512
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Dec 2020 22:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201206/170f6a30/attachment.htm>


More information about the gerrit-log mailing list