Change in libosmocore[master]: Introduce 'osmo_tlv_prot' abstraction for validation of TLV protocols

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21534 )

Change subject: Introduce 'osmo_tlv_prot' abstraction for validation of TLV protocols
......................................................................


Patch Set 7:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21534/5/include/osmocom/gsm/tlv.h 
File include/osmocom/gsm/tlv.h:

https://gerrit.osmocom.org/c/libosmocore/+/21534/5/include/osmocom/gsm/tlv.h@626 
PS5, Line 626: *
> missing '*!'
Done


https://gerrit.osmocom.org/c/libosmocore/+/21534/5/src/gsm/tlv_parser.c 
File src/gsm/tlv_parser.c:

https://gerrit.osmocom.org/c/libosmocore/+/21534/5/src/gsm/tlv_parser.c@661 
PS5, Line 661: in
> Nevermind, I see that it's actually 'const'.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21534/5/src/gsm/tlv_parser.c@664 
PS5, Line 664:  */
> missing \returns
Done


https://gerrit.osmocom.org/c/libosmocore/+/21534/5/src/gsm/tlv_parser.c@713 
PS5, Line 713:  */
> missing \returns
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If1e1d9adfa141ca86001dbd62a6a339f9bf9a912
Gerrit-Change-Number: 21534
Gerrit-PatchSet: 7
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Dec 2020 12:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201206/7294390f/attachment.htm>