Change in libosmocore[master]: core/linuxlist: do not use 'new' as a parameter name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Dec 5 17:37:48 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21553 )

Change subject: core/linuxlist: do not use 'new' as a parameter name
......................................................................

core/linuxlist: do not use 'new' as a parameter name

'new' is a reserved keyword in C++, so including this header from
a C++ project (like osmo-pcu) breaks compilation.  Let's rename
it in the same way as it's already done in this file: add '_'.

Change-Id: I7f7d9143edca75ce932601386a8766b0a62c0e24
Fixes: I8ef73a62fe9846ce45058eb21cf999dd3eed5741
---
M include/osmocom/core/linuxlist.h
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/linuxlist.h b/include/osmocom/core/linuxlist.h
index 2c3a0a4..5ccd462 100644
--- a/include/osmocom/core/linuxlist.h
+++ b/include/osmocom/core/linuxlist.h
@@ -579,11 +579,11 @@
  * reference of the first entry if it exists.
  */
 static inline void hlist_move_list(struct hlist_head *old,
-				   struct hlist_head *new)
+				   struct hlist_head *_new)
 {
-	new->first = old->first;
-	if (new->first)
-		new->first->pprev = &new->first;
+	_new->first = old->first;
+	if (_new->first)
+		_new->first->pprev = &_new->first;
 	old->first = NULL;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21553
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7f7d9143edca75ce932601386a8766b0a62c0e24
Gerrit-Change-Number: 21553
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201205/bb03add0/attachment.htm>


More information about the gerrit-log mailing list