Change in osmo-gsm-tester[master]: enb: Set cipher and integrity algos via scenario file

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21533 )

Change subject: enb: Set cipher and integrity algos via scenario file
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21533/1/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl 
File src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21533/1/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl@227 
PS1, Line 227:     cipher_algo_pref: [${(', '.join(list(dict.fromkeys(enb.cipher_algo)))).replace('EEA', '')}],
why are EEA and EIA being dropped?
If they are not supported, we should not silence it, it means resources.conf/scenarios are wrong.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21533/1/sysmocom/defaults.conf 
File sysmocom/defaults.conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21533/1/sysmocom/defaults.conf@133 
PS1, Line 133:   cipher_algo_list:
If not all ENS supports all these then clearly you don't want to have the 3 of them here.
Rather put the shared ones here, and if srsenb supports more, then put it below under "srsneb:" defaults.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21533
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Id1fbf31c71967d67de11a23d52d32e44c0925061
Gerrit-Change-Number: 21533
Gerrit-PatchSet: 1
Gerrit-Owner: ninjab3s <nils.fuerste at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Dec 2020 19:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/98a69eaf/attachment.htm>