Change in libosmocore[master]: bssgp: Add osmo_tlv_prot_def for BSSGP

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21544 )

Change subject: bssgp: Add osmo_tlv_prot_def for BSSGP
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c 
File src/gb/gprs_bssgp_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c@209 
PS1, Line 209: static const uint8_t crt_bss_pfc_nack_ies[] = { BSSGP_IE_TLLI, BSSGP_IE_PACKET_FLOW_ID, BSSGP_IE_CAUSE };
feeling like I'm looking at wireshark code ;)

It may make sense to have macros to ease naming, so that for each line here you pass simply BSSGP_PDUT_DL_UNITDATA to it, and below in osmo_pdef_bssgp you simply pass eg BSSGP_PDUT_DL_UNITDATA, "UL-UNITDATA"

But now the work is already done so not sure if worth it.


https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c@239 
PS1, Line 239: 		[BSSGP_PDUT_DL_UNITDATA] = MSG_DEF("DL-UNITDAT", dl_ud_ies),
missing A in data.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21544
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7e4226463f3c935134b5c2c737696fbfd1dd5815
Gerrit-Change-Number: 21544
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Dec 2020 19:02:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/a418ae11/attachment.htm>