This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21497 ) Change subject: nm_bts_sm_fsm: Fix peer_has_no_avstate_offline not applied for nanobts ...................................................................... nm_bts_sm_fsm: Fix peer_has_no_avstate_offline not applied for nanobts The condition was set in st_op_disabled_notinstalled_on_enter(): """ site_mgr->peer_has_no_avstate_offline = (bts->type == GSM_BTS_TYPE_NANOBTS); """ However, at startup of the FSM the oneneter func of the default initial state is not called. In any case, if called it would be too early since the type is not known yet (because its parsed later on at the VTY with the "type" command, that's after the "bts X" node is called and the bts_sm is allocated. So we need to make sure to always enable it, also for nanobts. Change-Id: Ic6049a44ae3fca1b8e968fe800c268f579e7cad4 --- M src/osmo-bsc/nm_bts_sm_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/nm_bts_sm_fsm.c b/src/osmo-bsc/nm_bts_sm_fsm.c index e5b5a3c..815eea6 100644 --- a/src/osmo-bsc/nm_bts_sm_fsm.c +++ b/src/osmo-bsc/nm_bts_sm_fsm.c @@ -78,8 +78,8 @@ "have your .cfg with 'type nanobts'. Otherwise, you probably " "are using an old osmo-bts; automatically adjusting OML " "behavior to be backward-compatible.\n"); - site_mgr->peer_has_no_avstate_offline = true; } + site_mgr->peer_has_no_avstate_offline = true; nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_ENABLED); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6049a44ae3fca1b8e968fe800c268f579e7cad4 Gerrit-Change-Number: 21497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/9ba8a47d/attachment.htm>