This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504 ) Change subject: add osmo_vty.py ...................................................................... Patch Set 2: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py File src/osmo_gsm_tester/obj/osmo_vty.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py@3 PS1, Line 3: # Copyright (C) 2016-2017 by sysmocom - s.f.m.c. GmbH it's 2020 already! https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py@44 PS1, Line 44: def connect(self): Please if this API is aimed at be used internally also through __enter__ and __exit__ add comments sections as in obj/bts.py (PROTECTED, PUBLIC - INTERNAL API, PUBLIC (test API included)) It really helps at understanding at first glance which kind of stuff is used internally or aimed at be used by tests, etc. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py@56 PS1, Line 56: time.sleep(3) this should be Mainloop.sleep. You most probably want to use Mainloop.wait() instead of all this loop here. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py@125 PS1, Line 125: time.sleep(.1) again, don't use time.sleep here or anywhere. Mainloop.sleep, and even better if you use Mainloop.wait() -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7c17b143b7c690b8c4105ee7c6272670046fa91d Gerrit-Change-Number: 21504 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Dec 2020 17:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/366745ed/attachment.htm>