This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/21529 )
Change subject: mnl: Use mnl_socket_open() insatead of mnl_socket_open2()
......................................................................
mnl: Use mnl_socket_open() insatead of mnl_socket_open2()
mnl_socket_open2 is not yet available on e.g. Debian 8. Furthermore,
osmo_fd_register() will set the CLOEXEC flag on every file descriptor
anyway, so there is no benefit from using mnl_socket_open2() at all.
Change-Id: I0b37ffa148ff0c0a22281b490820353f5fef00eb
---
M src/mnl.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/21529/1
diff --git a/src/mnl.c b/src/mnl.c
index 13d9c9e..a7d3511 100644
--- a/src/mnl.c
+++ b/src/mnl.c
@@ -74,7 +74,7 @@
olm->priv = priv;
olm->mnl_cb = mnl_cb;
- olm->mnls = mnl_socket_open2(bus, SOCK_CLOEXEC);
+ olm->mnls = mnl_socket_open(bus);
if (!olm->mnls) {
LOGP(DLGLOBAL, LOGL_ERROR, "Error creating netlink socket for bus %d: %s\n",
bus, strerror(errno));
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21529
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0b37ffa148ff0c0a22281b490820353f5fef00eb
Gerrit-Change-Number: 21529
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/456545f7/attachment.htm>