Change in osmo-ttcn3-hacks[master]: pcu: Verify LLC UI dummy frames are not appended at end of rlcmac DL ...

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419 )

Change subject: pcu: Verify LLC UI dummy frames are not appended at end of rlcmac DL block
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419/1/pcu/PCU_Tests.ttcn@2588 
PS1, Line 2588: 		if (dl_block.data_egprs.blocks[1].hdr.length_ind != 127) {
> Duplicate of line 2584?
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419/1/pcu/PCU_Tests.ttcn@2605 
PS1, Line 2605: rclamc
> rlcmac
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419/1/pcu/PCU_Tests.ttcn@2611 
PS1, Line 2611: rclamc
> same
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7e0d9ed2475dbf989fbf932c8b83117ff5fb28fc
Gerrit-Change-Number: 21419
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 03 Dec 2020 23:48:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/8269f922/attachment.htm>