This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21502 ) Change subject: Handle BTS/BBTRANSC Get Attributes (Ack) in NM FSMs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21502/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21502/1/include/osmocom/bsc/gsm_data.h@402 PS1, Line 402: bool get_attr_sent; > Hmm, I thought the idea of FSMs is to replace state variables and boolean flags... […] Doing so would make the FSM enourmously complicated, with lots more of states and lots more of repeated logic on each of them. Having booleans to track FSMs details on each state is nothing new in osmocom projects, you can find that being used in several other FSMs already. The important part is that those booleans/flags are managed inside the FSM code so it's clear when are they used and how. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8ec39c7e1f956ffce9aecd58a5590c43200ba086 Gerrit-Change-Number: 21502 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Thu, 03 Dec 2020 20:32:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/ea7a06b1/attachment.htm>