This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21463 ) Change subject: Introduce NM GPRS CELL FSM ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21463/2/src/osmo-bsc/nm_gprs_cell_fsm.c File src/osmo-bsc/nm_gprs_cell_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21463/2/src/osmo-bsc/nm_gprs_cell_fsm.c@99 PS2, Line 99: OSMO_ASSERT(msgb); /* if (!msgb); break; */ > why not if(!msgb)? Should we really segfault on low memory? That comment should go away, it's a leftover I left now I'm doing tests if I find something failing. TBH, it's not important, that's not going to happen theoretically, in linux malloc won't ever fail and return NULL, rather the process will be stalled until the kernel allocates memory for it or it is killed by OOM killer, so it really doesn't matter. ASSERT has less lines than if + break, that's the only reason. Adding the assert there rpovides a quick security + easy way to see where the issue was, in the really improbable scenario where NULL is returned, which is really not expected. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I074f4496aa153b5f84e6ce85f413754efe64d831 Gerrit-Change-Number: 21463 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Thu, 03 Dec 2020 15:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/0c323a46/attachment.htm>