Change in osmo-sgsn[master]: gbproxy: Cosmetics: use longer lines

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Dec 3 14:24:37 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21475 )

Change subject: gbproxy: Cosmetics: use longer lines
......................................................................

gbproxy: Cosmetics: use longer lines

Change-Id: I9426bf4be2faa0da7848cb102b20cc539948b3f5
---
M src/gbproxy/gb_proxy.c
1 file changed, 5 insertions(+), 9 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, approved



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 2fd276d..d8b828c 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1025,9 +1025,9 @@
 		/* If we receive a BVC reset on the signalling endpoint, we
 		 * don't want the SGSN to reset, as the signalling endpoint
 		 * is common for all point-to-point BVCs (and thus all BTS) */
-		struct gbproxy_nse *nse;
+
 		/* Ensure the NSE peer is there and clear all PtP BVCs */
-		nse = gbproxy_nse_by_nsei_or_new(cfg, nsei);
+		struct gbproxy_nse *nse = gbproxy_nse_by_nsei_or_new(cfg, nsei);
 		if (!nse) {
 			LOGP(DGPRS, LOGL_ERROR, "Could not create NSE(%05u)\n", nsei);
 			bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, 0, msg);
@@ -1037,8 +1037,7 @@
 		gbproxy_cleanup_peers(cfg, nsei, 0);
 
 		/* FIXME: only do this if SGSN is alive! */
-		LOGPNSE(nse, LOGL_INFO, "Tx fake "
-			"BVC RESET ACK of BVCI=0\n");
+		LOGPNSE(nse, LOGL_INFO, "Tx fake BVC RESET ACK of BVCI=0\n");
 		bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_RESET_ACK, nsei, 0, 0);
 		return 0;
 	} else {
@@ -1080,12 +1079,9 @@
 			 * PDU, this means we can extend our local
 			 * state information about this particular cell
 			 * */
-			memcpy(from_peer->ra,
-				TLVP_VAL(tp, BSSGP_IE_CELL_ID),
-				sizeof(from_peer->ra));
+			memcpy(from_peer->ra, TLVP_VAL(tp, BSSGP_IE_CELL_ID), sizeof(from_peer->ra));
 			gsm48_parse_ra(&raid, from_peer->ra);
-			LOGPBVC(from_peer, LOGL_INFO, "Cell ID %s\n",
-			     osmo_rai_name(&raid));
+			LOGPBVC(from_peer, LOGL_INFO, "Cell ID %s\n", osmo_rai_name(&raid));
 		}
 		if (cfg->route_to_sgsn2)
 			*copy_to_sgsn2 = 1;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21475
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9426bf4be2faa0da7848cb102b20cc539948b3f5
Gerrit-Change-Number: 21475
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/e37fa330/attachment.htm>


More information about the gerrit-log mailing list