This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21465 ) Change subject: ns2: Add filtering by NSE/NSEI ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > looks good. But somehow I cannot find any place where the NSE log context is set on packet receive? > > > > Interesting, I added the NSE context everywhere I found the NSVC context being set. > > I'll check what's up with rx > > Maybe rx is not handled inside the library but only set by applications? Or even the NSVC case is broken? In any case, we should set the context as soon as possible once we know the NSVC/NSE to which a message belongs. The NSE should IMHO be known immediately, as one 'bind' (FR AF_PACKET socket, UDP socket) always directly belongs to one NSE. The NSVC should be known almost at the same time: remote peer address (UDP) or netdev name (FR). My conclusion is that it simply was not working for NS receive. I found no log_set_context anywhere in osmo-sgsn (even for a pre-ns2 commit like 86336af2a3) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I63c0e85f82f5d08c5a6f535da94b8648498439d2 Gerrit-Change-Number: 21465 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Thu, 03 Dec 2020 14:19:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/36333431/attachment.htm>