Change in osmo-bts[master]: power_control: generalize power control state structure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Dec 2 12:51:38 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21441 )

Change subject: power_control: generalize power control state structure
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21441/1/include/osmo-bts/gsm_data.h 
File include/osmo-bts/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bts/+/21441/1/include/osmo-bts/gsm_data.h@165 
PS1, Line 165: uint8_t current;
             : 	uint8_t max;
             : 	bool fixed;
> This structure is a bit special: in case of Downlink, it stores attenuation in dB;  in case of Uplin […]
In that case what about adding a union and having 2 different variables inside the union?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21441
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8c6ad8d14349e8a05084c2912644c5202f951f52
Gerrit-Change-Number: 21441
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Dec 2020 12:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/abfdb414/attachment.htm>


More information about the gerrit-log mailing list