Change in osmo-bsc[master]: OML: sysmobts: add state to track feature negotiation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Dec 2 03:01:24 UTC 2020


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21451 )


Change subject: OML: sysmobts: add state to track feature negotiation
......................................................................

OML: sysmobts: add state to track feature negotiation

Add variables to track feature negotiation for sysmobts. In preparation
for the NSVC MO which need to check for IPv6 feature.

Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
3 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/21451/1

diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 22839d6..de0994f 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -295,6 +295,8 @@
 			uint16_t bts_id;
 			uint32_t flags;
 			uint32_t rsl_ip;
+			bool feature_dynamic;
+			bool feature_negotiated;
 		} ip_access;
 		struct {
 			struct {
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 73dc2d0..dab5bb6 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -596,6 +596,8 @@
 				     osmo_bts_has_feature(&bts->features, i), osmo_bts_has_feature(&bts->model->features, i));
 			}
 		}
+
+		bts->ip_access.feature_negotiated = true;
 	}
 
 	/* Parse Attribute Response Info content for 3GPP TS 52.021 §9.4.28 Manufacturer Dependent State */
diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c
index f9dc8b3..32823bb 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c
@@ -502,6 +502,11 @@
 	/* First of all, remove deferred drop if enabled */
 	osmo_timer_del(&bts->oml_drop_link_timer);
 
+	if (is_sysmobts_v2(bts)) {
+		bts->ip_access.feature_negotiated = false;
+		bts->ip_access.feature_dynamic = true;
+	}
+
 	if (!bts->oml_link)
 		return;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280
Gerrit-Change-Number: 21451
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/21bbe876/attachment.htm>


More information about the gerrit-log mailing list