Change in osmo-mgw[master]: mgcp_client: get rid of magic numbers for E1 slots

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Dec 1 20:02:45 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/21385 )

Change subject: mgcp_client: get rid of magic numbers for E1 slots
......................................................................


Patch Set 4:

(2 comments)

(ensure all comments are sent)

https://gerrit.osmocom.org/c/osmo-mgw/+/21385/3/src/libosmo-mgcp-client/Makefile.am 
File src/libosmo-mgcp-client/Makefile.am:

https://gerrit.osmocom.org/c/osmo-mgw/+/21385/3/src/libosmo-mgcp-client/Makefile.am@12 
PS3, Line 12: 	$
> this one is correct, we use the #define
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/21385/3/src/libosmo-mgcp-client/Makefile.am@19 
PS3, Line 19: 	$
> this one is incorrect, as it means we create a runtime library dependency to  a library of which we  […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/21385
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iee134d70f05883fcd2e58e0b9c78ed70aea16695
Gerrit-Change-Number: 21385
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Dec 2020 20:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/822fd9cb/attachment.htm>


More information about the gerrit-log mailing list