Change in osmo-bts[master]: struct gsm_bts: move ul_power_{target, hysteresis} to ul_power_ctrl

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 1 19:34:35 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21434 )

Change subject: struct gsm_bts: move ul_power_{target,hysteresis} to ul_power_ctrl
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21434/1/include/osmo-bts/bts.h 
File include/osmo-bts/bts.h:

https://gerrit.osmocom.org/c/osmo-bts/+/21434/1/include/osmo-bts/bts.h@304 
PS1, Line 304: * Target value to strive to */
             : 		int target;
             : 		/* Tolerated deviation from target */
             : 		int hysteresis;
I know, unrelated to this patch, but it would be great  if at least the  comment would state in which unit (dBm for target / dB for hysteresis?) they are.  Another approach that I typically use in such situations is to append the unit like target_dBm and hysteresis_mdB.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21434
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3886c7aedf3870536f1750f864cf698302ddf2df
Gerrit-Change-Number: 21434
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 01 Dec 2020 19:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/de1e44a7/attachment.htm>


More information about the gerrit-log mailing list