Change in osmo-bts[master]: sched_lchan_tchh: fix frame number and fill FACCH gap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Dec 1 12:39:07 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21329 )

Change subject: sched_lchan_tchh: fix frame number and fill FACCH gap
......................................................................


Patch Set 2:

(1 comment)

Regarding the frame numbers, not sure why you prefer to stay with the remapping API.  This is a performance critical part of the implementation, and storing frame numbers together with the Uplink measurements in a ring-buffer would be a significant improvement, since you don't need to do any for / if / assert() at all.  I don't want to block you, but still would prefer the ring-buffer approach.

Regarding the measurements, it's still unclear to me why do you memcpy() samples averaged over the whole FACCH/H block.  My proposal was to keep averaging samples as usual, like there is no FACCH/H at all. I think we need to schedule a Jitsi call, but let's see if I can propose something in the form of a patch today.

https://gerrit.osmocom.org/c/osmo-bts/+/21329/2/src/osmo-bts-trx/sched_lchan_tchh.c 
File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21329/2/src/osmo-bts-trx/sched_lchan_tchh.c@71 
PS2, Line 71: 	unsigned int fn_tch_end;	
ws



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9fa3815feb2b4da608ab7df716a87ba1f2f91
Gerrit-Change-Number: 21329
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 01 Dec 2020 12:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/b7fba826/attachment.htm>


More information about the gerrit-log mailing list