This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20927 ) Change subject: NS2: rework handling of unknown primitive ...................................................................... NS2: rework handling of unknown primitive Use prim_str() method to get the human readable string. Define unhandled events with a nop in the switch() Depends-on: Ibf610fbd929dddc4a4e235152447caff522d4eb2 (libosmocore) Change-Id: I50188afb83ac142e22d4bda4e8050eb4de962e70 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index cb47998..934d8fc 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -574,11 +574,13 @@ the_pcu.bvc_unblocked = 0; } break; + case NS_AFF_CAUSE_SNS_FAILURE: + break; default: - LOGP(DPCU, LOGL_NOTICE, - "NS: %s Unknown prim %d from NS\n", + LOGP(DPCU, LOGL_DEBUG, + "NS: %s Unknown affecting cause %s / %d from NS\n", get_value_string(osmo_prim_op_names, nsp->oph.operation), - nsp->oph.primitive); + gprs_ns2_aff_cause_prim_str(nsp->u.status.cause), nsp->u.status.cause); break; } } @@ -613,11 +615,13 @@ case PRIM_NS_STATUS: gprs_ns_prim_status_cb(nsp); break; + case PRIM_NS_CONGESTION: + break; default: - LOGP(DPCU, LOGL_NOTICE, - "NS: %s Unknown prim %d from NS\n", + LOGP(DPCU, LOGL_DEBUG, + "NS: %s Unknown prim %s / %d from NS\n", get_value_string(osmo_prim_op_names, oph->operation), - oph->primitive); + gprs_ns2_prim_str((gprs_ns2_prim) oph->primitive), oph->primitive); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I50188afb83ac142e22d4bda4e8050eb4de962e70 Gerrit-Change-Number: 20927 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/2c8ab533/attachment.htm>