Change in docker-playground[master]: common: Introduce OSMOCOM_REPO_MIRROR param

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Dec 1 11:32:22 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21239 )

Change subject: common: Introduce OSMOCOM_REPO_MIRROR param
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/docker-playground/+/21239/1/osmo-nitb-master/Dockerfile 
File osmo-nitb-master/Dockerfile:

https://gerrit.osmocom.org/c/docker-playground/+/21239/1/osmo-nitb-master/Dockerfile@6 
PS1, Line 6: ARG	DISTRO
> Here you do (as well as in some other cases) […]
I would say it doesn't really matter if it's added or not here if it's not used later on, I see points for and against for both.

I'd say it's fine keeping it here if not used in case somebody wants to use it here in the future. Feel free to say if you really want it in a specific way and i change it, otherwsise I say let's merge as it is. As you see it's tons of files so it's expected that some file may be a bit different than others.



-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I8010b08f3dabacfb3c13a44eece6c7a490e0742e
Gerrit-Change-Number: 21239
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Dec 2020 11:32:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/7c50b064/attachment.htm>


More information about the gerrit-log mailing list