Change in osmo-bts[master]: bts-trx: Ensure RFMUTE state is set properly at startup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 31 15:18:34 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19830 )

Change subject: bts-trx: Ensure RFMUTE state is set properly at startup
......................................................................


Patch Set 1: Code-Review+1

Wouldn't this cause proprietary implementations to reject the command and stop working? I remember we had some problems with SETFORMAT, so you introduced a VTY command to disable it. If so, we should only send 'RFMUTE 1' for locked transceivers, and do not send 'RFMUTE 0' by default.

P.S. In general, I think we should implicitly state in the documentation that unknown commands shall be rejected, and the transceiver shall continue to operate as before (i.e. do not stop working completely).


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I96b64cdc901d6f216df628d7be57a67af4a21e25
Gerrit-Change-Number: 19830
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Aug 2020 15:18:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200831/3f2b5007/attachment.htm>


More information about the gerrit-log mailing list