Change in osmo-mgw[master]: mgcp_client: Allow submitting and parsing IPv6 addr in SDP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 31 08:36:53 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19888 )

Change subject: mgcp_client: Allow submitting and parsing IPv6 addr in SDP
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/19888/2/src/libosmo-mgcp-client/mgcp_client.c 
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/19888/2/src/libosmo-mgcp-client/mgcp_client.c@a375 
PS2, Line 375: 	if (st
> you're removing any length checks in this function. […]
How can they go out of bounds?
1- This same strlen() being here is telling (maybe a bug) that the string is null terminated.
2- Other string accesses afterwards like strncmp or pointer deferring early returns if string is different/shorter than expected.

So the only real difference here is that I'm not early returning on super long lines (>16 chars, which anyway needed to be changed to accomodate ipv6 addresses), and in long lines anyway osmo_strlcpy would truncate to INET6_ADDRSTRLEN chars, so we are fine here.
The only thing I need to improve is checking the return code of osmo_strlcpy in case it was truncated, and then do early return.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
Gerrit-Change-Number: 19888
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 31 Aug 2020 08:36:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200831/fed6fc7c/attachment.htm>


More information about the gerrit-log mailing list