Change in osmo-mgw[master]: mgcp_e1: remove unused struct member trunk->e1.line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri Aug 28 14:29:11 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19711 )

Change subject: mgcp_e1: remove unused struct member trunk->e1.line
......................................................................


Patch Set 1: Code-Review+1

We do huge amounts of object lookups in long llists all over the osmocom source trees.
Caching the e1.line seems a premature optimization.

Instead we should do some profiling, and the result will most likely point at other places that take a lot longer than getting an object from a list of one member. (In general, I assume osmocom needs to introduce hashmaps at some point, to look up conn ids on various interfaces instead of iterating every time)


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4ff52285917ce3885b8dad3a16270999c9da0aa
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 28 Aug 2020 14:29:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200828/97ba33f9/attachment.htm>


More information about the gerrit-log mailing list