Change in libosmocore[master]: lapd_test: add a test checking SAPI0/SAPI3 prioritization

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19847 )

Change subject: lapd_test: add a test checking SAPI0/SAPI3 prioritization
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19847/1/tests/lapd/lapd_test.c 
File tests/lapd/lapd_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/19847/1/tests/lapd/lapd_test.c@802 
PS1, Line 802: SAMB
SABM


https://gerrit.osmocom.org/c/libosmocore/+/19847/1/tests/lapd/lapd_test.c@806 
PS1, Line 806: if 0
             : 	/* OS#4731: currently these checks would fail, uncomment when the bug is fixed */
             : 	OSMO_ASSERT(memcmp(pp1.oph.msg->l2h, ua_pr, sizeof(ua_pr)) == 0);
             : 	OSMO_ASSERT(memcmp(pp2.oph.msg->l2h, est_req_sdcch_sapi3,
             : 			   sizeof(est_req_sdcch_sapi3)) == 0);
             : #endif
I think we usually submit a test first, but one that doesn't ASSERT but simply prints error messages.  We then merge the patch fixing the bug together with a change in the .ok / .err file but without touching the unit test.

Commenting the important part of the test out here sort-of defeats the purpose of merging the test before the fix, as it doesn't really test what's relevant.

We can go ahead with this, but I'm just explaining how I believe we normally handle those situations.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19847
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ied0f8bb683de8e37bcfa984c2877aa1cec1c0b4b
Gerrit-Change-Number: 19847
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 27 Aug 2020 13:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200827/1aa92c89/attachment.htm>