Change in osmo-bsc[master]: CBC VTY: tweak VTY doc strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 27 09:36:40 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19832 )

Change subject: CBC VTY: tweak VTY doc strings
......................................................................


Patch Set 1:

> TBH, I find the VTY cmds for this section a bit weird (I know it's not directly related to this commit).

I agree. What is also "weird" is that the client mode is indicated by listen-PORT while the server mode is indicated by remote-IP. (that's because there is a default listen-ip that often doesn't need changing -- setting a port is most important, but you always need an explicit remote-ip)

In this patch I did not aim for fixing that.

But let's in fact take another look at this in https://gerrit.osmocom.org/c/osmo-bsc/+/19837
because instead of adding a 'restart' command, we could change the VTY and add 'server' / 'client' commands instead.

If we want to add binding to a specific address we'll have to add new commands though.

Since the CBSP feature was not functional in the last release, I think we still have all freedom to adjust the vty config without having to worry about users' setups.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I434835ae8dad9e726f296e648b1b55fb00be8ccb
Gerrit-Change-Number: 19832
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Aug 2020 09:36:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200827/257fc9db/attachment.htm>


More information about the gerrit-log mailing list