This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19824 ) Change subject: fix bsc_sapi_n_reject(): dlci is unsigned, use uint8_t ...................................................................... fix bsc_sapi_n_reject(): dlci is unsigned, use uint8_t Change-Id: I5f04f16caecb58a28e119512267999fdc18ff172 --- M include/osmocom/bsc/gsm_08_08.h M src/osmo-bsc/gsm_08_08.c M tests/bsc/bsc_test.c M tests/handover/handover_test.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/19824/1 diff --git a/include/osmocom/bsc/gsm_08_08.h b/include/osmocom/bsc/gsm_08_08.h index b46a8d3..e55bf2c 100644 --- a/include/osmocom/bsc/gsm_08_08.h +++ b/include/osmocom/bsc/gsm_08_08.h @@ -6,7 +6,7 @@ struct gsm_subscriber_connection; -void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci); +void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci); void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr); int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel); void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg); diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index e7ef728..e5457c4 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -60,7 +60,7 @@ } /*! BTS->MSC: tell MSC a SAPI was not established. */ -void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci) +void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci) { int rc; struct msgb *resp; diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c index dd2b1bb..86d8972 100644 --- a/tests/bsc/bsc_test.c +++ b/tests/bsc/bsc_test.c @@ -223,7 +223,7 @@ OSMO_ASSERT(0); } -void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci) {} +void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci) {} void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr) {} int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel) { return 0; } diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 6fb145e..31d4b6f 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -1794,7 +1794,7 @@ void trau_send_frame() {} int osmo_bsc_sigtran_send(struct gsm_subscriber_connection *conn, struct msgb *msg) { return 0; } int osmo_bsc_sigtran_open_conn(struct gsm_subscriber_connection *conn, struct msgb *msg) { return 0; } -void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci) {} +void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci) {} void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr) {} int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel) { return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5f04f16caecb58a28e119512267999fdc18ff172 Gerrit-Change-Number: 19824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200826/e349ed82/attachment.htm>