Change in osmo-trx[master]: add kernel style .clang-format with 120 chars per line limit

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 24 14:28:03 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19640 )

Change subject: add kernel style .clang-format with 120 chars per line limit
......................................................................


Patch Set 1: Code-Review+2

> Well it's being used if it exists by qt-creator and by visual studio, how would I know what kind of setup other people use?

The part of the setup that everyone uses is git.  So if you want to start with some automatic syntax verification based on clang-format (which I thought this was about), it should be integrated with git.  There are probably various different ways to do this, but I would think a local hook on the client would be useful, warning if a commit introduces malformatted code.

Something like https://github.com/barisione/clang-format-hooks ?

In terms of enforcement, if you wanted to go there, this would happen to have on the gerrit side.

> I also want to have it in this project, so it can be used in this project, not somewhere where I need to check out a different repo and copy the file just to have it in this project which means no one is going to use it.

In general, we try to share whatever can be shared between projects in common repositories, rather than copy+pasting.  But if you only want this in osmo-trx, I misread your intentions.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19640
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1dc6610d7adfa1a52f3d41ad04544806c2be2c39
Gerrit-Change-Number: 19640
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Aug 2020 14:28:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200824/8d95541b/attachment.htm>


More information about the gerrit-log mailing list