Change in osmo-pcu[master]: encoding: constify 'tbf' in UL/DL assignment functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 24 10:53:16 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19730 )

Change subject: encoding: constify 'tbf' in UL/DL assignment functions
......................................................................

encoding: constify 'tbf' in UL/DL assignment functions

Change-Id: I9b80ce22914a355592502c936046b233c3ba216d
---
M src/encoding.cpp
M src/encoding.h
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/encoding.cpp b/src/encoding.cpp
index 881dc61..5d2434b 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -538,7 +538,7 @@
 void Encoding::write_packet_uplink_assignment(
 	bitvec * dest, uint8_t old_tfi,
 	uint8_t old_downlink, uint32_t tlli, uint8_t use_tlli,
-	struct gprs_rlcmac_ul_tbf *tbf, uint8_t poll, uint8_t rrbp, uint8_t alpha,
+	const struct gprs_rlcmac_ul_tbf *tbf, uint8_t poll, uint8_t rrbp, uint8_t alpha,
 	uint8_t gamma, int8_t ta_idx, int8_t use_egprs)
 {
 	// TODO We should use our implementation of encode RLC/MAC Control messages.
@@ -629,7 +629,7 @@
 /* generate downlink assignment */
 void Encoding::write_packet_downlink_assignment(RlcMacDownlink_t * block,
 	bool old_tfi_is_valid, uint8_t old_tfi, uint8_t old_downlink,
-	struct gprs_rlcmac_dl_tbf *tbf, uint8_t poll, uint8_t rrbp,
+	const struct gprs_rlcmac_dl_tbf *tbf, uint8_t poll, uint8_t rrbp,
 	uint8_t alpha, uint8_t gamma, int8_t ta_idx,
 	uint8_t ta_ts, bool use_egprs)
 {
diff --git a/src/encoding.h b/src/encoding.h
index 2f6b273..525f8e6 100644
--- a/src/encoding.h
+++ b/src/encoding.h
@@ -59,13 +59,13 @@
 	static void write_packet_uplink_assignment(
 			bitvec * dest, uint8_t old_tfi,
 			uint8_t old_downlink, uint32_t tlli, uint8_t use_tlli,
-			struct gprs_rlcmac_ul_tbf *tbf, uint8_t poll, uint8_t rrbp,
+			const struct gprs_rlcmac_ul_tbf *tbf, uint8_t poll, uint8_t rrbp,
 			uint8_t alpha, uint8_t gamma, int8_t ta_idx,
 			int8_t use_egprs);
 
 	static void write_packet_downlink_assignment(RlcMacDownlink_t * block,
 			bool old_tfi_is_valid, uint8_t old_tfi, uint8_t old_downlink,
-			struct gprs_rlcmac_dl_tbf *tbf, uint8_t poll, uint8_t rrbp,
+			const struct gprs_rlcmac_dl_tbf *tbf, uint8_t poll, uint8_t rrbp,
 			uint8_t alpha, uint8_t gamma,
 			int8_t ta_idx, uint8_t ta_ts, bool use_egprs);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9b80ce22914a355592502c936046b233c3ba216d
Gerrit-Change-Number: 19730
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200824/e785f3f5/attachment.htm>


More information about the gerrit-log mailing list