Change in osmo-pcu[master]: pcu_l1_if: cosmetic: move struct 'gprs_rlcmac_pdch' into the for loop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 24 10:53:12 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19729 )

Change subject: pcu_l1_if: cosmetic: move struct 'gprs_rlcmac_pdch' into the for loop
......................................................................

pcu_l1_if: cosmetic: move struct 'gprs_rlcmac_pdch' into the for loop

Change-Id: I5bc270ddb6064e5086a801061c2eff074c293e77
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 578e5aa..fbd7e92 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -489,7 +489,6 @@
 {
 	struct gprs_rlcmac_bts *bts = bts_main_data();
 	struct gprs_bssgp_pcu *pcu;
-	struct gprs_rlcmac_pdch *pdch;
 	struct in_addr ia;
 	int rc = 0;
 	unsigned int trx_nr, ts_nr;
@@ -631,7 +630,7 @@
 		}
 
 		for (ts_nr = 0; ts_nr < ARRAY_SIZE(bts->trx[0].pdch); ts_nr++) {
-			pdch = &bts->trx[trx_nr].pdch[ts_nr];
+			struct gprs_rlcmac_pdch *pdch = &bts->trx[trx_nr].pdch[ts_nr];
 			if ((info_ind->trx[trx_nr].pdch_mask & (1 << ts_nr))) {
 				/* FIXME: activate dynamically at RLCMAC */
 				if (!pdch->is_enabled()) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19729
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5bc270ddb6064e5086a801061c2eff074c293e77
Gerrit-Change-Number: 19729
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200824/c64a407f/attachment.htm>


More information about the gerrit-log mailing list