Change in osmo-pcu[master]: encoding: fix RRBP field in write_packet_uplink_assignment()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Aug 21 22:03:48 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19784 )

Change subject: encoding: fix RRBP field in write_packet_uplink_assignment()
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> Seems like we have no test coverage, if this kind of bug shows up?

I am not sure if we support scheduling the ACK using a formula different than N+13... If yes, for sure we should add a test case. If not, well, let's wait for somebody who really needs this feature ;)


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19784
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9eb362292e9f4c16d4b8f8d4253df0422062eeb4
Gerrit-Change-Number: 19784
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 21 Aug 2020 22:03:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200821/3f5df041/attachment.htm>


More information about the gerrit-log mailing list