Change in osmo-ttcn3-hacks[master]: SIP_Templates: tr_SIP_BYE: allow violations of the spec (Contact header)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri Aug 21 12:05:47 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19704 )

Change subject: SIP_Templates: tr_SIP_BYE: allow violations of the spec (Contact header)
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> How did we end up changing this?  I don't recall any changes to the BYE.  Only INVITE was recently changed in I5c35c5a4bad2fbe76c22ac6d7ee37c832e0ba246.
> 
> In general, I think we then should preferably fix the implementation rather than accepting our IUT to behave outside of the spec?

The invite headers seems to be used later in the invite, because it's added to the session handle. The bye is using all headers without any check.

I would abandon this commit and open a bug on the github page of sofia-sip.

https://osmocom.org/issues/4718


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19704
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida17247a90bf30b14d7a6587b92f14c1c7eb9f7a
Gerrit-Change-Number: 19704
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 21 Aug 2020 12:05:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200821/b5793782/attachment.htm>


More information about the gerrit-log mailing list