Change in osmo-bsc[master]: Count handover per BTS as well as per BSC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Aug 20 16:47:14 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19736 )

Change subject: Count handover per BTS as well as per BSC
......................................................................


Patch Set 2:

(5 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/include/osmocom/bsc/bts.h@90 
PS1, Line 90: 
> Drop empty line
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/include/osmocom/bsc/bts.h@150 
PS1, Line 150: 	[BTS_CTR_HANDOVER_ATTEMPTED] = 		{"handover:attempted", "Intra-BSC handover attempts."},
> I copied it from the bsc_ctr_desc where almost all counter descriptions end with one. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c 
File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c@91 
PS1, Line 91:  * Assume conn_get_bts() is not NULL
> No conn_get_bts used here...
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c@93 
PS1, Line 93: #define ho_count_bts(bts, counter) do { \
> so if bts=NULL you log you increment the rate_ctr but you don't do it...
Yeah, well it will be changed two commits later anyway when we count towards the unknown bts counter.
I'd leave it here as is.


https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c@630 
PS1, Line 630: 	ho_count_bsc(BSC_CTR_INTER_BSC_HO_IN_ATTEMPTED);
> You can use ho_count() here for both.
You're right. Leftover from an earlier version



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19736
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I025ef14e2cfd2eea8880212c9406372ce0bf9296
Gerrit-Change-Number: 19736
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Aug 2020 16:47:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200820/c52c7a29/attachment.htm>


More information about the gerrit-log mailing list