This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19731 ) Change subject: encoding: do not encode out of range Timing Advance values ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19731/1/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19731/1/src/encoding.cpp@147 PS1, Line 147: if (ta > 63) /* No TIMING_ADVANCE_VALUE: */ > I would rather do this kind of checks when storing them inside a MS object Well, feel free to do so. For now it's the easiest solution, and I don't see a reason why it should not be done here [too]. API wise, we're accepting 0..255 from some caller here, and we cannot blindly trust that the MS/TBF API would never give us a wrong value, ever after you fix it. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I342288ea4ef1e218e5744e9be6a8e528d4e697fa Gerrit-Change-Number: 19731 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2020 11:29:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200820/5ed6089e/attachment.htm>