Change in osmo-pcu[master]: pcu_l1_if: use proper format specifier for PCUIF version

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Aug 20 11:19:36 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19726 )

Change subject: pcu_l1_if: use proper format specifier for PCUIF version
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/19726/1/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19726/1/src/pcu_l1_if.cpp@499 
PS1, Line 499: 		fprintf(stderr, "PCU interface version number of BTS (%u) is "
> This should actually be a PRIu32: […]
Again, '%u' works fine for 'uint32_t', and we use it in many places (e.g. to print TDMA frame number). Please point me to a man page / documentation where it's stated that 'PRIu32' shall be used instead of '%u'. Currently I am not convinced.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19726
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibd15a678a7a8fc840422e2280b0d358138a67e0c
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 20 Aug 2020 11:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200820/025febd5/attachment.htm>


More information about the gerrit-log mailing list